[webkit-reviews] review granted: [Bug 26382] [ES5] Implement Function.prototype.bind : [Attachment 108382] New patch, reentrant implementation.

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 26382: [ES5] Implement Function.prototype.bind
https://bugs.webkit.org/show_bug.cgi?id=26382

Attachment 108382: New patch, reentrant implementation.
https://bugs.webkit.org/attachment.cgi?id=108382&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108382&action=review


> Source/JavaScriptCore/runtime/JSBoundFunction.cpp:92
> +    // FIXME: our instanceof implementation will have already (incorrectly)
performed
> +    // a [[Get]] of .prototype from the bound function object, which is
incorrect!
> +    proto = m_targetFunction->get(exec, exec->propertyNames().prototype);

You should add a test showing this is incorrect.

> Source/JavaScriptCore/runtime/JSBoundFunction.h:66
> +    WriteBarrier<JSObject> m_targetFunction;
> +    WriteBarrier<Unknown> m_boundThis;
> +    WriteBarrier<Unknown> m_boundArgs;

How are these marked?