[webkit-reviews] review denied: [Bug 68321] [EFL] Use C++ type cast instead of C style type cast : [Attachment 108354] Patch

[bugzilla-daemon at webkit.org]

Raphael Kubo da Costa <kubo at profusion.mobi> has denied Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 68321: [EFL] Use C++ type cast instead of C style type cast
https://bugs.webkit.org/show_bug.cgi?id=68321

Attachment 108354: Patch
https://bugs.webkit.org/attachment.cgi?id=108354&action=review

------- Additional Comments from Raphael Kubo da Costa <kubo at profusion.mobi>
View in context: https://bugs.webkit.org/attachment.cgi?id=108354&action=review


I was going to comment on all occurrences which changed "Foo* p = ..." to "Foo
*p = ..." but gave up about halfway into the patch.

> Source/WebKit/efl/ewk/ewk_auth_soup.cpp:82
> +    Ewk_Auth_Data *auth_data = static_cast<Ewk_Auth_Data*>(data);

Wrong '*' position.

> Source/WebKit/efl/ewk/ewk_contextmenu.cpp:106
> +    Ewk_Context_Menu_Item *item =
static_cast<Ewk_Context_Menu_Item*>(malloc(sizeof(*item)));

Ditto.

> Source/WebKit/efl/ewk/ewk_frame.cpp:689
> +    Ewk_Hit_Test *hit_test = static_cast<Ewk_Hit_Test*>(calloc(1,
sizeof(Ewk_Hit_Test)));

Ditto.

> Source/WebKit/efl/ewk/ewk_view.cpp:210
> +    Ewk_View_Smart_Data *ptr =
static_cast<Ewk_View_Smart_Data*>(evas_object_smart_data_get(o))

The placement of the first '*' could be fixed here.

> Source/WebKit/efl/ewk/ewk_view.cpp:473
> +    Ewk_View_Smart_Data *sd = static_cast<Ewk_View_Smart_Data*>(data);

Wrong position for the first '*'.

> Source/WebKit/efl/ewk/ewk_view.cpp:481
> +    Ewk_View_Smart_Data *sd = static_cast<Ewk_View_Smart_Data*>(data);

Ditto.

> Source/WebKit/efl/ewk/ewk_view.cpp:727
> +    const Ewk_View_Smart_Class* api = (Ewk_View_Smart_Class*)(sc);

No C++ cast here.