[webkit-reviews] review granted: [Bug 68597] DFG JIT should support integer division : [Attachment 108295] the patch - more goodness added

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 68597: DFG JIT should support integer division
https://bugs.webkit.org/show_bug.cgi?id=68597

Attachment 108295: the patch - more goodness added
https://bugs.webkit.org/attachment.cgi?id=108295&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108295&action=review


> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:549
> +	   // have speculatins in place that take care of that separately. We
only

Typo: speculations

> Source/JavaScriptCore/jit/JITArithmetic.cpp:1058
> +    // in the heap to go doubly, resulting in double predictions getting
predicted to all

What’s "go doubly"? Do you just mean "go double"? Or get a double value?

> Source/JavaScriptCore/jit/JITArithmetic.cpp:1062
> +    // FIXME: This will fail to do its magic if the result is zero.

This comment would be clearer if “fail to do its magic” was replaced by a more
specific phrase.