[webkit-reviews] review denied: [Bug 68235] [GTK][WK2] Initial implementation of WebInspector : [Attachment 108318] App changes for WebInspector implementation - revision 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 22 10:10:54 PDT 2011


Martin Robinson <mrobinson at webkit.org> has denied Ravi Phaneendra Kasibhatla
<ravi.kasibhatla at motorola.com>'s request for review:
Bug 68235: [GTK][WK2] Initial implementation of WebInspector
https://bugs.webkit.org/show_bug.cgi?id=68235

Attachment 108318: App changes for WebInspector implementation - revision 2
https://bugs.webkit.org/attachment.cgi?id=108318&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108318&action=review


> Tools/MiniBrowser/gtk/BrowserWindow.c:193
> +    if (g_getenv("WEBKIT_ENABLE_WEB_INSPECTOR")) {
> +	   WKPageGroupRef groupRef =
WKPageGetPageGroup(WKViewGetPage(window->webView));
> +	   WKPreferencesRef preferencesRef =
WKPageGroupGetPreferences(groupRef);
> +	   WKPreferencesSetDeveloperExtrasEnabled(preferencesRef, true);
> +    }

Why not just enable it always?


More information about the webkit-reviews mailing list