[webkit-reviews] review denied: [Bug 68371] [GTK][WEBKIT2] Add WebKitWebSettings GTK+ API : [Attachment 108311] WebKitWebSetting GTK+ API

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Nayan Kumar K
<nayankk at motorola.com>'s request for review:
Bug 68371: [GTK][WEBKIT2] Add WebKitWebSettings GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=68371

Attachment 108311: WebKitWebSetting GTK+ API
https://bugs.webkit.org/attachment.cgi?id=108311&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108311&action=review


We should decide whether we want the documention on the properties or the
methods and then link back from the other place.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebSettings.cpp:76
> +    PROP_ENABLE_JAVA_SCRIPT,

JavaScript is camel case, but it's always written as one word.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebSettings.cpp:201
> +				       g_param_spec_boolean(

No need for a newline here.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebSettings.cpp:218
> +				       g_param_spec_boolean(

No need for a newline here.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebSettings.cpp:234
> +				       g_param_spec_boolean(

No need for a newline here.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebSettings.cpp:332
> +				       g_param_spec_boolean(

Ditto.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebSettings.cpp:407
> + * webkit_web_settings_get_enable_java_script:

JavaScript is always written as one word.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebSettings.cpp:409
> + * Check if Java Script execution within a page is supported or not.

Ditto.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebSettings.cpp:411
> + * Returns: %TRUE If Java Script is enabled.

Ditto.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebSettings.cpp:413
> + * @see_also: webkit_web_settings_set_enable_java_script

Ditto. Etc. :)