[webkit-reviews] review denied: [Bug 68615] [Gtk] Title attribute is not respected on option elements : [Attachment 108326] Patch.

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Deepak Sherveghar
<bpwv64 at motorola.com>'s request for review:
Bug 68615: [Gtk] Title attribute is not respected on option elements
https://bugs.webkit.org/show_bug.cgi?id=68615

Attachment 108326: Patch.
https://bugs.webkit.org/attachment.cgi?id=108326&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108326&action=review


Looks good to me, but I have a few ChangeLog nits below.

> Source/WebCore/ChangeLog:3
> +	   [Gtk] Respect Title attribute on Option elements.

This line should be the bug title: [Gtk] Title attribute is not respected on
option elements

> Source/WebCore/ChangeLog:8
> +	   Set Tooltip on menuitem widget created from GTKAction.

Watch you capilization here. Probably better to say something like: Set tooltip
on PopupMenuGtk items created from GtkActions.

> Source/WebCore/ChangeLog:13
> +	   * platform/gtk/GtkPopupMenu.cpp:
> +	   (WebCore::GtkPopupMenu::appendItem):
> +	   * platform/gtk/PopupMenuGtk.cpp:
> +	   (WebCore::PopupMenuGtk::createGtkActionForMenuItem):

Please fill these out.