[webkit-reviews] review granted: [Bug 68533] [GTK]Popup drop-down menu contains extra empty spaces at beginning and occupies whole screen when items in popup reaches the height of display device : [Attachment 108282] proposed patch updated
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 22 08:38:03 PDT 2011
Martin Robinson <mrobinson at webkit.org> has granted Wajahat Siddiqui
<mdwajahatali.siddiqui at motorola.com>'s request for review:
Bug 68533: [GTK]Popup drop-down menu contains extra empty spaces at beginning
and occupies whole screen when items in popup reaches the height of display
device
https://bugs.webkit.org/show_bug.cgi?id=68533
Attachment 108282: proposed patch updated
https://bugs.webkit.org/attachment.cgi?id=108282&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108282&action=review
> Source/WebCore/ChangeLog:8
> + [GTK]Popup drop-down menu contains extra empty spaces at beginning
and
> + occupies whole screen when items in popup reaches the height of
display device.
> + https://bugs.webkit.org/show_bug.cgi?id=68533
> +
> + setting push_in to false as we dont want GTK+ to handle popup menu.
> +
Sorry. I missed a few other things here. The first line should be the bug
title. All stenences should start with a capital letter and end with a period.
I'll fix this and land it.
More information about the webkit-reviews
mailing list