[webkit-reviews] review denied: [Bug 68426] [WEBKIT2]Crash on mouse hover in MiniBrowser : [Attachment 108277] WKHitTestResult API and Minibrowser crash fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 22 07:25:42 PDT 2011
Anders Carlsson <andersca at apple.com> has denied Nayan Kumar K
<nayankk at motorola.com>'s request for review:
Bug 68426: [WEBKIT2]Crash on mouse hover in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=68426
Attachment 108277: WKHitTestResult API and Minibrowser crash fix
https://bugs.webkit.org/attachment.cgi?id=108277&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108277&action=review
I think WKHitTestResult should be in the UIProcess/API/c directory. Otherwise
the patch looks good. Please upload a new patch so we can land it.
> Tools/MiniBrowser/gtk/BrowserWindow.c:600
> + WKURLRef linkUrlRef = WKHitTestResultCopyAbsoluteLinkURL(hitTestResult);
This return value should be released.
More information about the webkit-reviews
mailing list