[webkit-reviews] review granted: [Bug 67483] Web Inspector: Console is always scrolled to the top : [Attachment 108033] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 67483: Web Inspector: Console is always scrolled to the top
https://bugs.webkit.org/show_bug.cgi?id=67483

Attachment 108033: Patch
https://bugs.webkit.org/attachment.cgi?id=108033&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108033&action=review


> Source/WebCore/inspector/front-end/ConsoleView.js:229
> +	   WebInspector.View.prototype.wasShown.call(this);

This is a View's flaw. wasShown should be abstract.

> Source/WebCore/inspector/front-end/ConsoleView.js:284
> +	   if (!this._scrollIntoViewTimer)

if (!this._isScrollIntoViewScheduled())