[webkit-reviews] review denied: [Bug 68553] [GTK][WK2] Error loading libMiniBrowserWebBundle.so : [Attachment 108206] Corrected libMiniBrowserWebBundle.so loading path

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has denied Ravi Phaneendra Kasibhatla
<ravi.kasibhatla at motorola.com>'s request for review:
Bug 68553: [GTK][WK2] Error loading libMiniBrowserWebBundle.so
https://bugs.webkit.org/show_bug.cgi?id=68553

Attachment 108206: Corrected libMiniBrowserWebBundle.so loading path
https://bugs.webkit.org/attachment.cgi?id=108206&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108206&action=review


As Martin says in comment 2 he has another plan for this bug as well. Maybe
discuss a bit more about the approach to take to fix this bug? r- because of
wrong use of libexecdir.

> Tools/MiniBrowser/gtk/GNUmakefile.am:8
> +	-DLIBEXECDIR=\""$(libexecdir)"\" \

This should point to the directory in $(top_builddir) storing the
libMiniBrowserWebBundle.so. As Carlos points out it's not installed, so not
available outside the build directory.