[webkit-reviews] review granted: [Bug 68588] [CG] ImageBufferData::getData has an invariant comparison in the inner part of a loop which doesn't get optimized out : [Attachment 108263] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 68588: [CG] ImageBufferData::getData has an invariant comparison in the
inner part of a loop which doesn't get optimized out
https://bugs.webkit.org/show_bug.cgi?id=68588

Attachment 108263: patch
https://bugs.webkit.org/attachment.cgi?id=108263&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108263&action=review


This code grows more and more unwieldy with each change.

> Source/WebCore/platform/graphics/cg/ImageBufferDataCG.cpp:195
> +		       reinterpret_cast<uint32_t*>(destRows + x)[0] =
reinterpret_cast<uint32_t*>(srcRows + x)[0];

Can this be a memcpy?