[webkit-reviews] review granted: [Bug 68586] Add X86 GPRInfo for DFG JIT. : [Attachment 108252] Fix

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 68586: Add X86 GPRInfo for DFG JIT.
https://bugs.webkit.org/show_bug.cgi?id=68586

Attachment 108252: Fix
https://bugs.webkit.org/attachment.cgi?id=108252&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108252&action=review


r=me

> Source/JavaScriptCore/dfg/DFGGPRInfo.h:46
> +    // These registers match the old JIT.

Let's call this "baseline JIT".

> Source/JavaScriptCore/dfg/DFGGPRInfo.h:59
> +    static const GPRReg argumentGPR0 = X86Registers::ecx; // regT2
> +    static const GPRReg argumentGPR1 = X86Registers::edx; // regT1
> +    static const GPRReg returnValueGPR = X86Registers::eax; // regT0
> +    static const GPRReg returnValueGPR2 = X86Registers::edx; // regT1

This numbering convention is not consistent. Would be good to make it so in a
future patch.