[webkit-reviews] review granted: [Bug 36793] CSS outline property on a narrow element has rabbit ear artifacts : [Attachment 108241] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 21 16:06:29 PDT 2011


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 36793: CSS outline property on a narrow element has rabbit ear artifacts
https://bugs.webkit.org/show_bug.cgi?id=36793

Attachment 108241: Patch
https://bugs.webkit.org/attachment.cgi?id=108241&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108241&action=review


> LayoutTests/fast/css/outline-narrowLine.html:22
> +<html>
> +<body>
> +<!--Outline around an empty span: WebKit does nothing here, as empty inlines
are ignored.-->
> +<p>
> +<span style="outline: solid red 5px"></span>
> +<p>
> +
> +<!--Outline around a span with a line break:-->
> +<p>
> +<span style="outline: solid green 5px"><br></span>
> +<p>
> +
> +<!--Outline around a span with a line break and an 'x':-->
> +<p>
> +<span style="outline: solid blue 5px"><br>x</span>
> +<p>
> +
> +<!--Outline around a span with an 'x' and two line breaks:-->
> +<p>
> +<span style="outline: solid purple 5px">x<br><br></span>
> +</body>
> +</html>

Can you make this test accentuate the outline? Try 50px-wide outlines.


More information about the webkit-reviews mailing list