[webkit-reviews] review denied: [Bug 68553] [GTK][WK2] Error loading libMiniBrowserWebBundle.so : [Attachment 108200] Corrected libMiniBrowserWebBundle.so loading path
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 21 12:09:09 PDT 2011
Martin Robinson <mrobinson at webkit.org> has denied Ravi Phaneendra Kasibhatla
<ravi.kasibhatla at motorola.com>'s request for review:
Bug 68553: [GTK][WK2] Error loading libMiniBrowserWebBundle.so
https://bugs.webkit.org/show_bug.cgi?id=68553
Attachment 108200: Corrected libMiniBrowserWebBundle.so loading path
https://bugs.webkit.org/attachment.cgi?id=108200&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108200&action=review
I'm going to add a helper function soon that discovers the binary location.
Could this patch be changed to simply find the shared object relative to the
binary location after that patch lands?
> Tools/MiniBrowser/gtk/main.c:48
> + g_free((gpointer)webBundlePath);
It's totally unecessary to cast to gpointer here.
More information about the webkit-reviews
mailing list