[webkit-reviews] review granted: [Bug 68501] [skia] Optimize ImageBuffer constructor when accelerated : [Attachment 108198] Updated per comments

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 68501: [skia] Optimize ImageBuffer constructor when accelerated
https://bugs.webkit.org/show_bug.cgi?id=68501

Attachment 108198: Updated per comments
https://bugs.webkit.org/attachment.cgi?id=108198&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108198&action=review


> Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.h:37
> +    static GraphicsContext3D* get();

this header file is kind of hilariously tiny now.  I actually think you can
remove the three #include lines and just leave a forward declaration of
GraphicsContext3D.

> Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp:85
> +    SkCanvas* canvas = new SkCanvas();

I think I'd still mildly prefer having this function be:
PassOwnPtr<SkCanvas> createAcceleratedCanvas(...)

and this line being OwnPtr<SkCanvas> canvas = adoptPtr(new SkCanvas())

just to try to keep the raw pointers down.  it's not a very practical concern