[webkit-reviews] review granted: [Bug 68501] [skia] Optimize ImageBuffer constructor when accelerated : [Attachment 108153] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 21 11:10:46 PDT 2011
James Robinson <jamesr at chromium.org> has granted Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 68501: [skia] Optimize ImageBuffer constructor when accelerated
https://bugs.webkit.org/show_bug.cgi?id=68501
Attachment 108153: Patch
https://bugs.webkit.org/attachment.cgi?id=108153&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108153&action=review
R=me, left some comments
> Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp:69
> + GraphicsContext3D* context3D = SharedGraphicsContext3D::create(0);
we really should remove the parameter from SharedGraphicsContext3D::create(),
it's not useful
> Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp:76
> + SkCanvas* canvas = new SkCanvas();
nit: if you move this down below line 83 I think you can avoid having to
manually delete this if the texture thingy fails
also, if you make this function return a PassOwnPtr<> then you can make this an
OwnPtr<SkCanvas>, have the return value be canvas.release() and not have to
worry about saying 'delete' at all
More information about the webkit-reviews
mailing list