[webkit-reviews] review granted: [Bug 68231] [EFL] Revert pointer operator coding style in ewk : [Attachment 108025] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 21 11:10:06 PDT 2011
Antonio Gomes <tonikitoo at webkit.org> has granted Lucas De Marchi
<demarchi at webkit.org>'s request for review:
Bug 68231: [EFL] Revert pointer operator coding style in ewk
https://bugs.webkit.org/show_bug.cgi?id=68231
Attachment 108025: Patch
https://bugs.webkit.org/attachment.cgi?id=108025&action=review
------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108025&action=review
> Source/WebKit/efl/ChangeLog:505
> + * WebCoreSupport/ChromeClientEfl.cpp:
> + (WebCore::ChromeClientEfl::exceededDatabaseQuota):
> + (WebCore::ChromeClientEfl::runOpenPanel):
> + * WebCoreSupport/EditorClientEfl.cpp:
> + (WebCore::EditorClientEfl::handleEditingKeyboardEvent):
> + * WebCoreSupport/FrameLoaderClientEfl.cpp:
> + (WebCore::FrameLoaderClientEfl::FrameLoaderClientEfl): remove name
of
> + unused function paramenter
> + (WebCore::FrameLoaderClientEfl::setCustomUserAgent):
> + (WebCore::FrameLoaderClientEfl::createJavaAppletWidget):
> + (WebCore::FrameLoaderClientEfl::didChangeTitle):
> + * WebCoreSupport/IconDatabaseClientEfl.cpp:
> + * WebCoreSupport/NotificationPresenterClientEfl.cpp:
> + * ewk/ewk_auth.cpp:
> + (ewk_auth_credentials_set):
> + * ewk/ewk_auth_soup.cpp:
> + (_Ewk_Auth_Data::ewk_auth_soup_dialog_class_init):
> + (_Ewk_Auth_Data::ewk_auth_soup_dialog_init):
> + (_Ewk_Auth_Data::ewk_auth_soup_dialog_session_feature_init):
> + (_Ewk_Auth_Data::ewk_auth_soup_credentials_set):
> + (_Ewk_Auth_Data::session_authenticate):
> + (_Ewk_Auth_Data::free_auth_data):
> + (_Ewk_Auth_Data::attach):
> + (_Ewk_Auth_Data::detach):
> + * ewk/ewk_contextmenu.cpp:
> + (ewk_context_menu_ref):
> + (ewk_context_menu_unref):
> + (ewk_context_menu_destroy):
> + (ewk_context_menu_item_list_get):
> + (ewk_context_menu_item_new):
> + (ewk_context_menu_item_select):
> + (ewk_context_menu_item_free):
> + (ewk_context_menu_item_type_get):
> + (ewk_context_menu_item_type_set):
> + (ewk_context_menu_item_action_get):
> + (ewk_context_menu_item_action_set):
> + (ewk_context_menu_item_title_get):
> + (ewk_context_menu_item_title_set):
> + (ewk_context_menu_item_checked_get):
> + (ewk_context_menu_item_checked_set):
> + (ewk_context_menu_item_enabled_get):
> + (ewk_context_menu_item_enabled_set):
> + (ewk_context_menu_new):
> + (ewk_context_menu_free):
> + (ewk_context_menu_item_append):
> + (ewk_context_menu_custom_get):
> + (ewk_context_menu_show):
> + * ewk/ewk_cookies.cpp:
> + (ewk_cookies_file_set):
> + (ewk_cookies_clear):
> + (ewk_cookies_get_all):
> + (ewk_cookies_cookie_del):
> + (ewk_cookies_cookie_free):
> + (ewk_cookies_policy_set):
> + (ewk_cookies_policy_get):
> + * ewk/ewk_frame.cpp:
> + (_ewk_frame_debug):
> + (_ewk_frame_loader_efl_get):
> + (kit):
> + (_ewk_frame_children_iterator_next):
> + (_ewk_frame_children_iterator_get_container):
> + (_ewk_frame_smart_add):
> + (_ewk_frame_smart_del):
> + (_ewk_frame_smart_resize):
> + (_ewk_frame_smart_set):
> + (_ewk_frame_smart_class_new):
> + (ewk_frame_view_get):
> + (ewk_frame_children_iterator_new):
> + (ewk_frame_child_find):
> + (ewk_frame_uri_set):
> + (ewk_frame_uri_get):
> + (ewk_frame_title_get):
> + (ewk_frame_name_get):
> + (ewk_frame_contents_size_get):
> + (_ewk_frame_contents_set_internal):
> + (ewk_frame_contents_set):
> + (ewk_frame_contents_alternate_set):
> + (ewk_frame_script_execute):
> + (ewk_frame_editable_get):
> + (ewk_frame_editable_set):
> + (ewk_frame_selection_get):
> + (ewk_frame_text_search):
> + (ewk_frame_text_matches_mark):
> + (ewk_frame_text_matches_unmark_all):
> + (ewk_frame_text_matches_highlight_set):
> + (ewk_frame_text_matches_highlight_get):
> + (_ewk_frame_rect_cmp_less_than):
> + (_ewk_frame_rect_is_negative_value):
> + (ewk_frame_text_matches_nth_pos_get):
> + (ewk_frame_stop):
> + (ewk_frame_reload):
> + (ewk_frame_reload_full):
> + (ewk_frame_back):
> + (ewk_frame_forward):
> + (ewk_frame_navigate):
> + (ewk_frame_back_possible):
> + (ewk_frame_forward_possible):
> + (ewk_frame_navigate_possible):
> + (ewk_frame_zoom_get):
> + (ewk_frame_zoom_set):
> + (ewk_frame_zoom_text_only_get):
> + (ewk_frame_zoom_text_only_set):
> + (ewk_frame_hit_test_free):
> + (ewk_frame_hit_test_new):
> + (ewk_frame_scroll_add):
> + (ewk_frame_scroll_set):
> + (ewk_frame_scroll_size_get):
> + (ewk_frame_scroll_pos_get):
> + (ewk_frame_visible_content_geometry_get):
> + (ewk_frame_paint_full_get):
> + (ewk_frame_paint_full_set):
> + (ewk_frame_feed_focus_in):
> + (ewk_frame_feed_focus_out):
> + (ewk_frame_feed_mouse_wheel):
> + (ewk_frame_feed_mouse_down):
> + (ewk_frame_feed_mouse_up):
> + (ewk_frame_feed_mouse_move):
> + (ewk_frame_feed_touch_event):
> + (_ewk_frame_handle_key_scrolling):
> + (ewk_frame_feed_key_down):
> + (ewk_frame_feed_key_up):
> + (ewk_frame_text_selection_type_get):
> + (ewk_frame_add):
> + (ewk_frame_init):
> + (ewk_frame_child_add):
> + (ewk_frame_core_gone):
> + (ewk_frame_core_get):
> + (ewk_frame_request_will_send):
> + (ewk_frame_request_assign_identifier):
> + (ewk_frame_did_perform_first_navigation):
> + (ewk_frame_view_state_save):
> + (ewk_frame_load_started):
> + (ewk_frame_load_provisional):
> + (ewk_frame_load_firstlayout_finished):
> + (ewk_frame_load_firstlayout_nonempty_finished):
> + (ewk_frame_load_document_finished):
> + (ewk_frame_load_finished):
> + (ewk_frame_load_error):
> + (ewk_frame_load_progress_changed):
> + (ewk_frame_contents_size_changed):
> + (ewk_frame_title_set):
> + (ewk_frame_view_create_for_view):
> + (ewk_frame_source_get):
> + (ewk_frame_resources_location_get):
> + (ewk_frame_uri_changed):
> + (ewk_frame_force_layout):
> + (ewk_frame_plugin_create):
> + (ewk_frame_editor_client_selection_changed):
> + (ewk_frame_editor_client_contents_changed):
> + * ewk/ewk_history.cpp:
> + (_ewk_history_item_new):
> + (_ewk_history_item_list_get):
> + (ewk_history_history_item_current_get):
> + (ewk_history_item_icon_surface_get):
> + * ewk/ewk_js.cpp:
> + * ewk/ewk_main.cpp:
> + (_ewk_init_body):
> + * ewk/ewk_network.cpp:
> + (ewk_network_proxy_uri_set):
> + (ewk_network_proxy_uri_get):
> + * ewk/ewk_private.h:
> + * ewk/ewk_protocol_handler_soup.h:
> + * ewk/ewk_settings.cpp:
> + (ewk_settings_web_database_path_set):
> + (ewk_settings_web_database_path_get):
> + (ewk_settings_icon_database_path_set):
> + (ewk_settings_icon_database_path_get):
> + (ewk_settings_icon_database_icon_surface_get):
> + (ewk_settings_icon_database_icon_object_add):
> + (ewk_settings_default_user_agent_get):
> + (ewk_settings_cache_directory_path_set):
> + (ewk_settings_cache_directory_path_get):
> + * ewk/ewk_tiled_backing_store.h:
> + * ewk/ewk_tiled_matrix.h:
> + * ewk/ewk_tiled_model.h:
> + * ewk/ewk_tiled_private.h:
> + * ewk/ewk_util.cpp:
> + (ewk_util_image_from_cairo_surface_add):
> + (ewk_util_dpi_get):
> + * ewk/ewk_util.h:
> + * ewk/ewk_view.cpp:
> + (_ewk_view_smart_changed):
> + (_ewk_view_repaints_resize):
> + (_ewk_view_repaint_add):
> + (_ewk_view_repaints_flush):
> + (_ewk_view_scrolls_resize):
> + (_ewk_view_scroll_add):
> + (_ewk_view_scrolls_flush):
> + (_ewk_view_smart_focus_in):
> + (_ewk_view_smart_focus_out):
> + (_ewk_view_smart_mouse_wheel):
> + (_ewk_view_smart_mouse_down):
> + (_ewk_view_smart_mouse_up):
> + (_ewk_view_smart_mouse_move):
> + (_ewk_view_smart_key_down):
> + (_ewk_view_smart_key_up):
> + (_ewk_view_smart_add_console_message):
> + (_ewk_view_smart_run_javascript_alert):
> + (_ewk_view_smart_run_javascript_confirm):
> + (_ewk_view_smart_should_interrupt_javascript):
> + (_ewk_view_smart_run_javascript_prompt):
> + (_ewk_view_on_focus_in):
> + (_ewk_view_on_focus_out):
> + (_ewk_view_on_mouse_wheel):
> + (_ewk_view_on_mouse_down):
> + (_ewk_view_on_mouse_up):
> + (_ewk_view_on_mouse_move):
> + (_ewk_view_on_key_down):
> + (_ewk_view_on_key_up):
> + (_ewk_view_core_frame_new):
> + (_ewk_view_priv_new):
> + (_ewk_view_priv_del):
> + (_ewk_view_smart_add):
> + (_ewk_view_smart_del):
> + (_ewk_view_smart_resize):
> + (_ewk_view_smart_move):
> + (_ewk_view_smart_calculate):
> + (_ewk_view_smart_show):
> + (_ewk_view_smart_hide):
> + (_ewk_view_smart_contents_resize):
> + (_ewk_view_smart_zoom_set):
> + (_ewk_view_smart_flush):
> + (_ewk_view_smart_pre_render_region):
> + (_ewk_view_smart_pre_render_relative_radius):
> + (_ewk_view_smart_pre_render_cancel):
> + (_ewk_view_zoom_animated_mark_stop):
> + (_ewk_view_zoom_animated_finish):
> + (_ewk_view_zoom_animated_current):
> + (_ewk_view_zoom_animator_cb):
> + (_ewk_view_zoom_animation_start):
> + (_ewk_view_viewport_attributes_compute):
> + (_ewk_view_smart_disable_render):
> + (_ewk_view_smart_enable_render):
> + (ewk_view_base_smart_set):
> + (ewk_view_fixed_layout_size_set):
> + (ewk_view_fixed_layout_size_get):
> + (ewk_view_theme_set):
> + (ewk_view_theme_get):
> + (ewk_view_frame_main_get):
> + (ewk_view_frame_focused_get):
> + (ewk_view_uri_set):
> + (ewk_view_uri_get):
> + (ewk_view_title_get):
> + (ewk_view_editable_get):
> + (ewk_view_bg_color_set):
> + (ewk_view_bg_color_get):
> + (ewk_view_text_search):
> + (ewk_view_text_matches_mark):
> + (ewk_view_text_matches_unmark_all):
> + (ewk_view_text_matches_highlight_set):
> + (ewk_view_text_matches_highlight_get):
> + (ewk_view_editable_set):
> + (ewk_view_selection_get):
> + (_ewk_view_editor_command):
> + (ewk_view_execute_editor_command):
> + (ewk_view_context_menu_forward_event):
> + (ewk_view_load_progress_get):
> + (ewk_view_stop):
> + (ewk_view_reload):
> + (ewk_view_reload_full):
> + (ewk_view_back):
> + (ewk_view_forward):
> + (ewk_view_navigate):
> + (ewk_view_back_possible):
> + (ewk_view_forward_possible):
> + (ewk_view_navigate_possible):
> + (ewk_view_history_enable_get):
> + (ewk_view_history_enable_set):
> + (ewk_view_history_get):
> + (ewk_view_zoom_get):
> + (ewk_view_zoom_set):
> + (ewk_view_zoom_weak_smooth_scale_get):
> + (ewk_view_zoom_weak_smooth_scale_set):
> + (ewk_view_zoom_weak_set):
> + (ewk_view_zoom_animated_mark_start):
> + (ewk_view_zoom_animated_mark_end):
> + (ewk_view_zoom_animated_mark_current):
> + (ewk_view_zoom_animated_mark_stop):
> + (ewk_view_zoom_animated_set):
> + (ewk_view_zoom_text_only_get):
> + (ewk_view_zoom_text_only_set):
> + (ewk_view_pre_render_region):
> + (ewk_view_pre_render_relative_radius):
> + (ewk_view_imh_get):
> + (ewk_view_pre_render_cancel):
> + (ewk_view_enable_render):
> + (ewk_view_disable_render):
> + (ewk_view_setting_user_agent_get):
> + (ewk_view_setting_user_agent_set):
> + (ewk_view_setting_user_stylesheet_get):
> + (ewk_view_setting_user_stylesheet_set):
> + (ewk_view_setting_auto_load_images_get):
> + (ewk_view_setting_auto_load_images_set):
> + (ewk_view_setting_auto_shrink_images_get):
> + (ewk_view_setting_auto_shrink_images_set):
> + (ewk_view_setting_enable_auto_resize_window_get):
> + (ewk_view_setting_enable_auto_resize_window_set):
> + (ewk_view_setting_enable_scripts_get):
> + (ewk_view_setting_enable_scripts_set):
> + (ewk_view_setting_enable_plugins_get):
> + (ewk_view_setting_enable_plugins_set):
> + (ewk_view_setting_enable_frame_flattening_get):
> + (ewk_view_setting_enable_frame_flattening_set):
> + (ewk_view_setting_scripts_window_open_get):
> + (ewk_view_setting_scripts_window_open_set):
> + (ewk_view_setting_scripts_can_close_windows_get):
> + (ewk_view_setting_scripts_can_close_windows_set):
> + (ewk_view_setting_resizable_textareas_get):
> + (ewk_view_setting_resizable_textareas_set):
> + (ewk_view_setting_private_browsing_get):
> + (ewk_view_setting_private_browsing_set):
> + (ewk_view_setting_offline_app_cache_get):
> + (ewk_view_setting_offline_app_cache_set):
> + (ewk_view_setting_caret_browsing_get):
> + (ewk_view_setting_caret_browsing_set):
> + (ewk_view_setting_encoding_custom_get):
> + (ewk_view_setting_encoding_custom_set):
> + (ewk_view_setting_encoding_default_get):
> + (ewk_view_setting_encoding_default_set):
> + (ewk_view_setting_encoding_detector_set):
> + (ewk_view_setting_encoding_detector_get):
> + (ewk_view_setting_enable_developer_extras_get):
> + (ewk_view_setting_enable_developer_extras_set):
> + (ewk_view_setting_font_minimum_size_get):
> + (ewk_view_setting_font_minimum_size_set):
> + (ewk_view_setting_font_minimum_logical_size_get):
> + (ewk_view_setting_font_minimum_logical_size_set):
> + (ewk_view_setting_font_default_size_get):
> + (ewk_view_setting_font_default_size_set):
> + (ewk_view_setting_font_monospace_size_get):
> + (ewk_view_setting_font_monospace_size_set):
> + (ewk_view_font_family_name_get):
> + (ewk_view_font_family_name_set):
> + (ewk_view_setting_spatial_navigation_get):
> + (ewk_view_setting_spatial_navigation_set):
> + (ewk_view_setting_local_storage_get):
> + (ewk_view_setting_local_storage_set):
> + (ewk_view_setting_page_cache_get):
> + (ewk_view_setting_page_cache_set):
> + (ewk_view_setting_local_storage_database_path_get):
> + (ewk_view_setting_local_storage_database_path_set):
> + (ewk_view_setting_minimum_timer_interval_set):
> + (ewk_view_setting_minimum_timer_interval_get):
> + (ewk_view_smart_data_get):
> + (ewk_view_repaints_get):
> + (ewk_view_scroll_requests_get):
> + (ewk_view_repaint_add):
> + (ewk_view_layout_if_needed_recursive):
> + (ewk_view_scrolls_process):
> + (ewk_view_paint_context_new):
> + (ewk_view_paint_context_free):
> + (ewk_view_paint_context_save):
> + (ewk_view_paint_context_restore):
> + (ewk_view_paint_context_clip):
> + (ewk_view_paint_context_paint):
> + (ewk_view_paint_context_paint_contents):
> + (ewk_view_paint_context_scale):
> + (ewk_view_paint_context_translate):
> + (ewk_view_paint):
> + (ewk_view_paint_contents):
> + (ewk_view_ready):
> + (ewk_view_input_method_state_set):
> + (ewk_view_title_set):
> + (ewk_view_uri_changed):
> + (ewk_view_load_started):
> + (ewk_view_frame_main_load_started):
> + (ewk_view_load_provisional):
> + (ewk_view_load_show):
> + (ewk_view_frame_main_cleared):
> + (ewk_view_frame_main_icon_received):
> + (ewk_view_load_finished):
> + (ewk_view_load_error):
> + (ewk_view_load_progress_changed):
> + (ewk_view_restore_state):
> + (ewk_view_window_create):
> + (ewk_view_window_close):
> + (ewk_view_mouse_link_hover_in):
> + (ewk_view_mouse_link_hover_out):
> + (ewk_view_toolbars_visible_set):
> + (ewk_view_toolbars_visible_get):
> + (ewk_view_statusbar_visible_set):
> + (ewk_view_statusbar_visible_get):
> + (ewk_view_statusbar_text_set):
> + (ewk_view_scrollbars_visible_set):
> + (ewk_view_scrollbars_visible_get):
> + (ewk_view_menubar_visible_set):
> + (ewk_view_menubar_visible_get):
> + (ewk_view_tooltip_text_set):
> + (ewk_view_add_console_message):
> + (ewk_view_run_javascript_alert):
> + (ewk_view_run_javascript_confirm):
> + (ewk_view_run_javascript_prompt):
> + (ewk_view_should_interrupt_javascript):
> + (ewk_view_exceeded_database_quota):
> + (ewk_view_run_open_panel):
> + (ewk_view_repaint):
> + (ewk_view_scroll):
> + (ewk_view_core_page_get):
> + (ewk_view_frame_create):
> + (ewk_view_plugin_create):
> + (ewk_view_popup_new):
> + (ewk_view_popup_destroy):
> + (ewk_view_popup_selected_set):
> + (ewk_view_download_request):
> + (ewk_view_js_window_object_clear):
> + (ewk_view_viewport_attributes_set):
> + (ewk_view_viewport_attributes_get):
> + (ewk_view_zoom_range_set):
> + (ewk_view_zoom_range_min_get):
> + (ewk_view_zoom_range_max_get):
> + (ewk_view_user_scalable_set):
> + (ewk_view_user_scalable_get):
> + (ewk_view_device_pixel_ratio_get):
> + (ewk_view_did_first_visually_nonempty_layout):
> + (ewk_view_dispatch_did_finish_loading):
> + (ewk_view_transition_to_commited_for_newpage):
> + (ewk_view_navigation_policy_decision):
> + (ewk_view_js_object_add):
> + (ewk_view_contents_size_changed):
> + (ewk_view_page_rect_get):
> + (ewk_view_need_touch_events_set):
> + (ewk_view_need_touch_events_get):
> + (ewk_view_mode_set):
> + (ewk_view_mode_get):
> + (ewk_view_editor_client_selection_changed):
> + (ewk_view_editor_client_contents_changed):
> + * ewk/ewk_view_single.cpp:
> + (_ewk_view_single_on_del):
> + (_ewk_view_single_smart_add):
> + (_ewk_view_single_smart_backing_store_add):
> + (_ewk_view_single_smart_resize):
> + (_ewk_view_4b_move_region_up):
> + (_ewk_view_4b_move_region_down):
> + (_ewk_view_4b_move_line_left):
> + (_ewk_view_4b_move_line_right):
> + (_ewk_view_4b_move_region_left):
> + (_ewk_view_4b_move_region_right):
> + (_ewk_view_4b_move_region):
> + (_ewk_view_single_scroll_process_single):
> + (_ewk_view_single_smart_scrolls_process):
> + (_ewk_view_single_smart_repaints_process):
> + (_ewk_view_single_smart_zoom_weak_set):
> + (_ewk_view_single_smart_zoom_weak_smooth_scale_set):
> + (_ewk_view_single_smart_bg_color_set):
> + (ewk_view_single_smart_set):
> + (_ewk_view_single_smart_class_new):
> + (ewk_view_single_add):
> + * ewk/ewk_view_tiled.cpp:
> + (_ewk_view_tiled_render_cb):
> + (_ewk_view_tiled_updates_process_pre):
> + (_ewk_view_tiled_smart_backing_store_add):
> + (_ewk_view_tiled_contents_size_changed_cb):
> + (_ewk_view_tiled_smart_add):
> + (_ewk_view_tiled_smart_scrolls_process):
> + (_ewk_view_tiled_smart_repaints_process):
> + (_ewk_view_tiled_smart_contents_resize):
> + (_ewk_view_tiled_smart_zoom_set):
> + (_ewk_view_tiled_smart_zoom_weak_set):
> + (_ewk_view_tiled_smart_zoom_weak_smooth_scale_set):
> + (_ewk_view_tiled_smart_flush):
> + (_ewk_view_tiled_smart_pre_render_region):
> + (_ewk_view_tiled_smart_pre_render_relative_radius):
> + (_ewk_view_tiled_smart_pre_render_cancel):
> + (_ewk_view_tiled_smart_disable_render):
> + (_ewk_view_tiled_smart_enable_render):
> + (ewk_view_tiled_smart_set):
> + (_ewk_view_tiled_smart_class_new):
> + (ewk_view_tiled_add):
> + (ewk_view_tiled_unused_cache_get):
> + (ewk_view_tiled_unused_cache_set):
> + * ewk/ewk_window_features.cpp:
> + (ewk_window_features_unref):
> + (ewk_window_features_ref):
> + (ewk_window_features_bool_property_get):
> + (ewk_window_features_int_property_get):
> + (ewk_window_features_new_from_core):
Please drop this of the changelog. It does not add anything since you changed
everywhere.
More information about the webkit-reviews
mailing list