[webkit-reviews] review requested: [Bug 66666] CSS: Implement 'font' property in CSSComputedStyle. : [Attachment 108164] Proposed patch v4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 21 08:15:31 PDT 2011


Andreas Kling <kling at webkit.org> has asked  for review:
Bug 66666: CSS: Implement 'font' property in CSSComputedStyle.
https://bugs.webkit.org/show_bug.cgi?id=66666

Attachment 108164: Proposed patch v4
https://bugs.webkit.org/attachment.cgi?id=108164&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
Keep the old (WebKit) behavior of getPropertyCSSValue('font-family'), i.e
returning a CSSPrimitiveValue for single-family values and a CSSValueList for
multiple families.
Added a comment about this in the CSSPropertyFontFamily block of
getPropertyCSSValue().
Also extended the test to exercise getPropertyCSSValue() as well as
getPropertyValue().


More information about the webkit-reviews mailing list