[webkit-reviews] review granted: [Bug 63595] MediaControlSeekButtonElement should support seeking by changing the playback rate. : [Attachment 108076] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 21 07:27:03 PDT 2011


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 63595: MediaControlSeekButtonElement should support seeking by changing the
playback rate.
https://bugs.webkit.org/show_bug.cgi?id=63595

Attachment 108076: Patch
https://bugs.webkit.org/attachment.cgi?id=108076&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108076&action=review


> Source/WebCore/html/shadow/MediaControlElements.cpp:588
> +    if (m_seekType == Scan)
> +	  
mediaElement()->setPlaybackRate(mediaElement()->defaultPlaybackRate());
> +

Would it make more sense to restore the original playback rate instead of
resuming at the default rate?

> Source/WebCore/html/shadow/MediaControlElements.cpp:614
> +    } else {
> +	   mediaElement()->setPlaybackRate(nextRate());
>      }

Nit: braces aren't needed here. I wonder why the style-pedant didn't catch
this?


More information about the webkit-reviews mailing list