[webkit-reviews] review denied: [Bug 68510] [EFL] build scripts modifications to support unit tests. : [Attachment 108123] Patch

[bugzilla-daemon at webkit.org]

Raphael Kubo da Costa <kubo at profusion.mobi> has denied Krzysztof
<k.czech at samsung.com>'s request for review:
Bug 68510: [EFL] build scripts modifications to support unit tests.
https://bugs.webkit.org/show_bug.cgi?id=68510

Attachment 108123: Patch
https://bugs.webkit.org/attachment.cgi?id=108123&action=review

------- Additional Comments from Raphael Kubo da Costa <kubo at profusion.mobi>
View in context: https://bugs.webkit.org/attachment.cgi?id=108123&action=review


> ChangeLog:3
> +	   [EFL] build scripts modifications to support unit tests.

Capital 'b' in build.

> ChangeLog:8
> +	   Added conditions for building gtest library and building unit tests.


This could be moved to the * Source/CMakeLists.txt line.

> Source/CMakeLists.txt:147
> +# Add google unit tests (gtest)

I'd rather have all this in Source/WebKit/efl instead.

> Source/WebKit/efl/tests/CMakeListsEfl.txt:37
> +ADD_DEFINITIONS(-DGTEST_TEST_FRAMEWORK)

Is this needed for gtest to work?

> Source/WebKit/efl/tests/CMakeListsEfl.txt:39
> +ADD_LIBRARY(efl_test_launcher

What links against this library?