[webkit-reviews] review requested: [Bug 68085] [GTK] Loader client implementation for WebKit2 GTK+ API : [Attachment 108136] Another approach using an interface
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 21 05:19:15 PDT 2011
Carlos Garcia Campos <cgarcia at igalia.com> has asked for review:
Bug 68085: [GTK] Loader client implementation for WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=68085
Attachment 108136: Another approach using an interface
https://bugs.webkit.org/attachment.cgi?id=108136&action=review
------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
This is another approach using an interface and a default implementation for
the interface that emit signals. It's undocumented for now, since we still
don't know which approach we'll finally use. I'm still not sure about the
default implementation, though. It's not clear when to use the default impl or
implement the interface. You can do the same with both, using the default impl
you don't need to create a GObject, but I think it's the only benefict. So, I
wonder whether we should provide only one way, an interface for the user to
implement, or just emit the signals from the view object.
More information about the webkit-reviews
mailing list