[webkit-reviews] review denied: [Bug 68153] [Qt][WK2] Implement Download support in WebProcess : [Attachment 107996] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 21 00:37:27 PDT 2011


Andreas Kling <kling at webkit.org> has denied Jesus Sanchez-Palencia
<jesus at webkit.org>'s request for review:
Bug 68153: [Qt][WK2] Implement Download support in WebProcess
https://bugs.webkit.org/show_bug.cgi?id=68153

Attachment 107996: Patch
https://bugs.webkit.org/attachment.cgi?id=107996&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107996&action=review


Looks good to me as well, though I'm gonna say r- due to the missing QWebError
code.

> Source/WebKit2/WebProcess/Downloads/qt/QtFileDownloader.cpp:141
> +	   // Don't use size + 1 so the ending '\0' byte from
QByteArray::data() is discarded.

This comment no longer applies.

> Source/WebKit2/WebProcess/Downloads/qt/QtFileDownloader.cpp:170
> +    ResourceError downloadError("Download", errorCode,
m_reply->url().toString(), translatedErrorMessage);

Since you're adding the "Download" class of errors, you also need to add a
corresponding error type to QWebError and hook that up.

> Source/WebKit2/WebProcess/Downloads/qt/QtFileDownloader.cpp:172
> +    // Don't use size + 1 so the ending '\0' byte from QByteArray::data() is
discarded.

This comment no longer applies.


More information about the webkit-reviews mailing list