[webkit-reviews] review requested: [Bug 68329] DFG should support continuous optimization : [Attachment 108112] the patch - fix review

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has asked  for review:
Bug 68329: DFG should support continuous optimization
https://bugs.webkit.org/show_bug.cgi?id=68329

Attachment 108112: the patch - fix review
https://bugs.webkit.org/attachment.cgi?id=108112&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
I addressed Geoff's review, mostly.  I believe that the GC must mark jettisoned
CodeBlocks.  I changed this so that ConservativeMarker no longer marks
CodeBlocks unconditionally; it will only do so if add() is passed a
JettisonedCodeBlocks.  Internally this is templatized, so we could support any
number of different "MarkHooks" in the ConservativeMarker.

All of the other issues are addressed.

I haven't addressed Oliver's two concerns (RefCounted on CodeBlock and
logging).  I'll look at the logging tomorrow.