[webkit-reviews] review denied: [Bug 65220] [Chromium] WebViewImpl doesn't proper deactivate focus : [Attachment 103694] fix style issues
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 20 16:57:24 PDT 2011
Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 65220: [Chromium] WebViewImpl doesn't proper deactivate focus
https://bugs.webkit.org/show_bug.cgi?id=65220
Attachment 103694: fix style issues
https://bugs.webkit.org/attachment.cgi?id=103694&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103694&action=review
> Source/WebKit/chromium/tests/WebViewTest.cpp:50
> +class WebViewTest : public testing::Test {
this looks like it is largely duplicating code from WebFrameTest.cpp. it
seems like it would be better to refactor so you can share code?
More information about the webkit-reviews
mailing list