[webkit-reviews] review denied: [Bug 68463] binaries in webkit.gyp should be split into a new file to break circular dependencies on webkit_support : [Attachment 108047] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 68463: binaries in webkit.gyp should be split into a new file to break
circular dependencies on webkit_support
https://bugs.webkit.org/show_bug.cgi?id=68463

Attachment 108047: Patch
https://bugs.webkit.org/attachment.cgi?id=108047&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108047&action=review


I just skimmed, but conceptually this looks fine.  r- because it looks like
there are build errors.  Also, you'll have to find a way to not break the
canary bots since src/webkit/webkit.gyp references WebKit.gyp:DumpRenderTree
directly (probably need to do a 3 sided change).

> Tools/DumpRenderTree/DumpRenderTree.gyp:433
> +# Local Variables:
> +# tab-width:2
> +# indent-tabs-mode:nil
> +# End:
> +# vim: set expandtab tabstop=2 shiftwidth=2:

Remove this and locally use tools/emacs/chrome-filetypes.el or
tools/vim/filetypes.vim intead.