[webkit-reviews] review granted: [Bug 65781] [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink : [Attachment 108058] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 20 15:13:57 PDT 2011
Ryosuke Niwa <rniwa at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 65781: [NRWT] REGRESSION: Local loader tests are failing on machines that
lost /tmp/LayoutTests symlink
https://bugs.webkit.org/show_bug.cgi?id=65781
Attachment 108058: Patch
https://bugs.webkit.org/attachment.cgi?id=108058&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108058&action=review
seems sane to me.
> Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm:409
> + } else {
> + ASSERT_NOT_REACHED(); // pathToLocalResource was passed a path it
doesn't know how to map.
> + }
Nit: curly brackets around a single line statement.
More information about the webkit-reviews
mailing list