[webkit-reviews] review granted: [Bug 40753] Hit testing on margins of body and head elements doesn't recur : [Attachment 108022] another attempt

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 40753: Hit testing on margins of body and head elements doesn't recur
https://bugs.webkit.org/show_bug.cgi?id=40753

Attachment 108022: another attempt
https://bugs.webkit.org/attachment.cgi?id=108022&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108022&action=review


> Source/WebCore/rendering/RenderBlock.cpp:4236
> -    if (!ancestor || ancestor->node()->rendererIsEditable() ==
childNode->rendererIsEditable())
> +    if (!ancestor || !ancestor->parent() || (ancestor->hasLayer() &&
ancestor->parent()->isRenderView())
> +	   || ancestor->node()->rendererIsEditable() ==
childNode->rendererIsEditable())

Putting this condition in a named function might make clearer what it's doing.