[webkit-reviews] review granted: [Bug 68188] Remove ScrollView::platformContentsSize : [Attachment 108043] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 20 13:11:27 PDT 2011

Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 68188: Remove ScrollView::platformContentsSize

Attachment 108043: Patch

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108043&action=review

Need to be sure to do more testing this time!

> Source/WebKit/mac/WebView/WebFrameView.mm:170
> -	       documentView = [[viewClass alloc] initWithFrame:[self bounds]];
> +	       documentView = [[viewClass alloc] initWithFrame:NSZeroRect];

Just calling the init method will do the same thing. I think that’s more
elegant than passing NSZeroRect.

More information about the webkit-reviews mailing list