[webkit-reviews] review granted: [Bug 67828] Rework script context creation/release notifications : [Attachment 108037] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Aaron Boodman <aa at chromium.org>'s
request for review:
Bug 67828: Rework script context creation/release notifications
https://bugs.webkit.org/show_bug.cgi?id=67828

Attachment 108037: Patch
https://bugs.webkit.org/attachment.cgi?id=108037&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108037&action=review


> Source/WebCore/bindings/v8/V8IsolatedContext.cpp:52
> +    : m_world(IsolatedWorld::create(worldId)), m_frame(proxy->frame())

These should be on separate lines.

> Source/WebKit/chromium/tests/WebFrameTest.cpp:294
> +	   Notification(WebFrame* frame, v8::Handle<v8::Context> context, int
worldId)
> +	       : frame(frame) ,
context(v8::Persistent<v8::Context>::New(context)), worldId(worldId)

This should be on separate lines.