[webkit-reviews] review denied: [Bug 68286] [Chromium] We need an API to expose blob creation to Chromium : [Attachment 107729] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Jay Civelli
<jcivelli at chromium.org>'s request for review:
Bug 68286: [Chromium] We need an API to expose blob creation to Chromium
https://bugs.webkit.org/show_bug.cgi?id=68286

Attachment 107729: Patch
https://bugs.webkit.org/attachment.cgi?id=107729&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107729&action=review


> Source/WebKit/chromium/public/WebBlob.h:48
> +    static v8::Handle<v8::Value> createBlobFromFile(const WebString& path,
long long size);

nit: no need to mention "Blob" in the method name.  just go with
WebBlob::createFromFile.

though it may seem heavier than you require, i think it would be better to make

WebBlob be a proper wrapper of WebCore::Blob.  WebCore::Blob is reference
counted,
so you can use WebPrivatePtr<T>.  follow the example of WebNode.

then, you can provide a WEBKIT_USING_V8 method name toV8Value().