[webkit-reviews] review denied: [Bug 64546] Redrawing dirty parts of a large table is very slow : [Attachment 107534] Changes for review comments

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Konstantin Shcheglov
<scheglov at google.com>'s request for review:
Bug 64546: Redrawing dirty parts of a large table is very slow
https://bugs.webkit.org/show_bug.cgi?id=64546

Attachment 107534: Changes for review comments
https://bugs.webkit.org/attachment.cgi?id=107534&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
table->needsLayout() is too broad. The table may only need "simplified" layout
(e.g., only a positioned child moved for example, in which case it won't ever
get to the code you added in layout() that invalidates collapsed borders.

You need the check to be !table->selfNeedsLayout() &&
!table->normalChildNeedsLayout() rather than simply !table->needsLayout().

You might want to add a test case for this situation just to cover it. Make a
table with a positioned block child. Do something to cause that positioned
child to need a layout and then change a cell's border style (such that it
would only need a repaint).