[webkit-reviews] review granted: [Bug 68382] Add settings to control the availability of the Web Audio API to WebKit and WebKit2. : [Attachment 108015] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 68382: Add settings to control the availability of the Web Audio API to
WebKit and WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=68382

Attachment 108015: Patch
https://bugs.webkit.org/attachment.cgi?id=108015&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108015&action=review


I think this version of runtime-enabled properties is not good. The feature
will still seem to be there for people who use best practices such as:

    if (webkitAudioContext in window)

I think that needs to be resolved. I believe V8 currently has a better version
of runtime-enabled features.

> Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:610
> +    Frame* frame = impl()->frame();
> +    Settings* settings = frame ? frame->settings() : 0;

We could make a helper function to get settings and so remove one line of code
from all of these.