[webkit-reviews] review granted: [Bug 68081] Page Scale affects window.scrollTo : [Attachment 108004] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Hin-Chung Lam
<hclam at google.com>'s request for review:
Bug 68081: Page Scale affects window.scrollTo
https://bugs.webkit.org/show_bug.cgi?id=68081

Attachment 108004: Patch
https://bugs.webkit.org/attachment.cgi?id=108004&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=108004&action=review


> Source/WebCore/ChangeLog:13
> +	   2. Frame::frameScaleFactor() returns the scale factor of this frame
with
> +	      respect to the container. So for the main frame it'll return the
scale
> +	      factor of the page, inner frames will return 1.0

I wonder about behavioral changes as result of this. For example, was
adjustForZoom() only ever called with the main frame's document before, or was
there a bug?

> Source/WebCore/page/FrameView.cpp:530
> +    bool overrideHidden = m_frame->page() && m_frame->page()->mainFrame() ==
m_frame && m_frame->frameScaleFactor() > 1;

Does this still require the m_frame->page()->mainFrame() == m_frame check?