[webkit-reviews] review granted: [Bug 68430] DFG JIT performs too many negative zero checks, and too many overflow checks : [Attachment 107980] the patch - fix bugs

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 68430: DFG JIT performs too many negative zero checks, and too many
overflow checks
https://bugs.webkit.org/show_bug.cgi?id=68430

Attachment 107980: the patch - fix bugs
https://bugs.webkit.org/attachment.cgi?id=107980&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107980&action=review


r=me, but remove the silly whitespace change :D

> Source/JavaScriptCore/dfg/DFGNode.h:201
> -#define NodeIdMask		0xFFF
> -#define NodeResultMask      0xF000
> -#define NodeMustGenerate   0x10000 // set on nodes that have side effects,
and may not trivially be removed by DCE.
> -#define NodeIsConstant     0x20000
> -#define NodeIsJump	      0x40000
> -#define NodeIsBranch       0x80000
> -#define NodeIsTerminal    0x100000
> -#define NodeHasVarArgs    0x200000
> -#define NodeClobbersWorld 0x400000
> -#define NodeMightClobber  0x800000
> +#define NodeIdMask		 0xFFF
> +#define NodeResultMask	0xF000
> +#define NodeMustGenerate    0x10000 // set on nodes that have side effects,
and may not trivially be removed by DCE.
> +#define NodeIsConstant      0x20000
> +#define NodeIsJump	       0x40000
> +#define NodeIsBranch        0x80000
> +#define NodeIsTerminal     0x100000
> +#define NodeHasVarArgs     0x200000
> +#define NodeClobbersWorld  0x400000
> +#define NodeMightClobber   0x800000

Die whitespace die!