[webkit-reviews] review denied: [Bug 67931] [GTK] Add WebKitWebContext to GTK API : [Attachment 107991] New patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 20 06:52:53 PDT 2011
Martin Robinson <mrobinson at webkit.org> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 67931: [GTK] Add WebKitWebContext to GTK API
https://bugs.webkit.org/show_bug.cgi?id=67931
Attachment 107991: New patch
https://bugs.webkit.org/attachment.cgi?id=107991&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107991&action=review
Looks good to me. There's one small thing below and we just need another
reviwer to review the API.
> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:58
> + WebKitWebContext* webContext =
WEBKIT_WEB_CONTEXT(g_object_new(WEBKIT_TYPE_WEB_CONTEXT, 0));
Sentinals have to be NULL, because 0 is a different size than NULL on 64-bit.
More information about the webkit-reviews
mailing list