[webkit-reviews] review granted: [Bug 68155] Web Inspector: refactor ConsoleView, Drawer, ConsolePanel trio. : [Attachment 107882] [Patch] rebaselined.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 20 05:55:41 PDT 2011

Tony Gentilcore <tonyg at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 68155: Web Inspector: refactor ConsoleView, Drawer, ConsolePanel trio.

Attachment 107882: [Patch] rebaselined.

------- Additional Comments from Tony Gentilcore <tonyg at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107882&action=review

> Source/WebCore/ChangeLog:10
> +	   screen" console animation.

The one line description suggestions this is just a refactor, but it is
actually a behavior change. Maybe there is a better one-line description?

> Source/WebCore/inspector/front-end/ConsolePanel.js:31
>      WebInspector.Panel.call(this, "console");

While you are here, why not add an /**@constructor*/ annotation to this
ConsolePanel ctor. Ditto for ConsoleView below.

> Source/WebCore/inspector/front-end/Drawer.js:63
> +	   this.immediatelyFinishAnimation();

Don't quite get why these are still necessary. Should the animation bits be
ripped out more completely or do some animations still exist?

More information about the webkit-reviews mailing list