[webkit-reviews] review granted: [Bug 68342] Web Inspector: streamline Console's MessageType and MessageSource semantics. : [Attachment 107886] [Patch] rebaselined 3.

[bugzilla-daemon at webkit.org]

Tony Gentilcore <tonyg at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 68342: Web Inspector: streamline Console's MessageType and MessageSource
semantics.
https://bugs.webkit.org/show_bug.cgi?id=68342

Attachment 107886: [Patch] rebaselined 3.
https://bugs.webkit.org/attachment.cgi?id=107886&action=review

------- Additional Comments from Tony Gentilcore <tonyg at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107886&action=review


> Source/WebCore/inspector/Inspector.json:335
> +	   "description": "Console domain defines methods and events for
interaction with the JavaScript console. Console collects messages created by
means of the <a
href='http://getfirebug.com/wiki/index.php/Console_API'>JavaScript Console
API</a>. One needs to enable this domain using <code>enable</code> command in
order to start receiving the console messages. Browser collects messages issued
while console domain is not enabled as well and reports them using
<code>messageAdded</code> notification upon enabling.",

I take it these strings are localized so it is fine to change them in place?