[webkit-reviews] review canceled: [Bug 68085] [GTK] Loader client implementation for WebKit2 GTK+ API : [Attachment 107339] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 20 05:14:08 PDT 2011


Carlos Garcia Campos <cgarcia at igalia.com> has canceled Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 68085: [GTK] Loader client implementation for WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=68085

Attachment 107339: Patch
https://bugs.webkit.org/attachment.cgi?id=107339&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
- It still uses the glib/gio async pattern, but it removes the load progress
callback
- It adds load-progress-changed and load-status-changed signals to notify about
the load progress. I'm using signals instead of properties in this case,
because progress and load-status only make sense while the view is loading, so
they are passed as parameters to the signal callbacks, but they are not saved
and there's no API to get them.
- It adds is-loading property.
- It adds all API docs missing in previous patch.


More information about the webkit-reviews mailing list