[webkit-reviews] review granted: [Bug 51159] [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl() : [Attachment 107353] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 20 04:52:51 PDT 2011


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Jarred Nicholls
<jarred at sencha.com>'s request for review:
Bug 51159: [Qt] Permit qrc resources to load in
QWebSettings::setUserStyleSheetUrl()
https://bugs.webkit.org/show_bug.cgi?id=51159

Attachment 107353: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=107353&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107353&action=review


> Source/WebCore/page/Page.cpp:689
> -    if (url.isLocalFile())
> +    
> +    // Allow any local file URL scheme to be loaded.
> +    if (SchemeRegistry::shouldTreatURLSchemeAsLocal(url.protocol()))

Is this change tested by non qt specific tests?


More information about the webkit-reviews mailing list