[webkit-reviews] review granted: [Bug 68399] Changelog class should have a method to return all entries : [Attachment 107929] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 19 21:55:36 PDT 2011

Ryosuke Niwa <rniwa at webkit.org> has granted Leandro Pereira
<leandro at profusion.mobi>'s request for review:
Bug 68399: Changelog class should have a method to return all entries

Attachment 107929: Patch

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107929&action=review

> Tools/ChangeLog:7
> +	   Implement ChangeLog.parse_entries_from_file(). This method returns a

> +	   generator of ChangeLogEntry objects, ordered from the latest to the

Can you put generator on the previous line? It seems odd to end a line with an

> Tools/ChangeLog:15
> +	   * Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test
> +	   case.

Seems like you can hit the entire thing in one line.

> Tools/Scripts/webkitpy/common/checkout/changelog.py:171
> +	       # If we've hit the next entry, return.

Nit: We don't return here, right?

More information about the webkit-reviews mailing list