[webkit-reviews] review requested: [Bug 68420] [chromium win] Creating lots of temporary canvas contexts will crash. : [Attachment 107959] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 19 19:30:13 PDT 2011


Ben Wells <benwells at chromium.org> has asked  for review:
Bug 68420: [chromium win] Creating lots of temporary canvas contexts will
crash.
https://bugs.webkit.org/show_bug.cgi?id=68420

Attachment 107959: Patch
https://bugs.webkit.org/attachment.cgi?id=107959&action=review

------- Additional Comments from Ben Wells <benwells at chromium.org>
This fix is not ready for landing, but it shows the second approach we could
take to help with this problem.

If this approach is the way to go, these changes (at least) should be made:

- be smarter about when to signal low memory by using the Windows registroy to
find the per-process limit (its not always 10000), and using GetGUIResources to
find out if we are getting close to that.

- push this change down (e.g. down to skia graphics context layer), to the
lowest layer we can put this and still have enough context to tell V8 we are
running low on resources.


More information about the webkit-reviews mailing list