[webkit-reviews] review granted: [Bug 68348] String#split is buggy : [Attachment 107951] Fix

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 68348: String#split is buggy
https://bugs.webkit.org/show_bug.cgi?id=68348

Attachment 107951: Fix
https://bugs.webkit.org/attachment.cgi?id=107951&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107951&action=review


> Source/JavaScriptCore/runtime/StringPrototype.cpp:806
> +    // 3. Let A be a new array created as if by the expression new
Array()where Array is the

Weird spacing.

> Source/JavaScriptCore/runtime/StringPrototype.cpp:813
> +    // 5. If limit is undefined, let lim = 2^32–1; else let lim =
ToUint32(limit).

I think you have a unicode!