[webkit-reviews] review denied: [Bug 68320] DFG JIT does not speculate aggressively enough on GetById : [Attachment 107797] the patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 19 14:33:54 PDT 2011
Oliver Hunt <oliver at apple.com> has denied Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 68320: DFG JIT does not speculate aggressively enough on GetById
https://bugs.webkit.org/show_bug.cgi?id=68320
Attachment 107797: the patch
https://bugs.webkit.org/attachment.cgi?id=107797&action=review
------- Additional Comments from Oliver Hunt <oliver at apple.com>
safeCast isn't actually safe -- you should use Checked<T> if you want overflow
safe arithmetic, or at least make safeCast use isInBounds from
CheckedArithmetic.h so that your overflow detection is correct.
More information about the webkit-reviews
mailing list