[webkit-reviews] review granted: [Bug 67510] Crash can occur when doing a PlatformCAAnimation::copy() with no valueFunction : [Attachment 107915] Patch to fix build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 19 13:55:36 PDT 2011


Adam Roben (:aroben) <aroben at apple.com> has granted Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 67510: Crash can occur when doing a PlatformCAAnimation::copy() with no
valueFunction
https://bugs.webkit.org/show_bug.cgi?id=67510

Attachment 107915: Patch to fix build
https://bugs.webkit.org/attachment.cgi?id=107915&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107915&action=review


> Source/WebCore/WebCore.vcproj/WebCore.vcproj:27330
> +		   <File
> +		      
RelativePath="..\platform\win\StructuredExceptionHandlerSupressor.h"
> +		       >
> +		   </File>

Indentation looks screwy here.

> Source/WebCore/platform/win/StructuredExceptionHandlerSupressor.h:45
> +	   // Windows puts an __try/__except block around some calls, such as
hooks.
> +	   // The exception handler then ignores system exceptions like invalid
addresses
> +	   // and null pointers. This class can be used to remove this block
and prevent
> +	   // it from catching the exception. Typically this will cause the
exception to crash 
> +	   // which is often desirable to allow crashlogs to be recorded for
debugging purposed.
> +	   // While this class is in scope we replace the Windows exception
handler with 0xffffffff, 
> +	   // which indicates that the exception should not be handled.

It would be good to include a link to the article that explains the 0xffffffff
and FS:[0] stuff.

>> Source/WebCore/platform/win/StructuredExceptionHandlerSupressor.h:52
>> +	    __asm mov [registration], eax
> 
> Extra space before [	[whitespace/braces] [5]

You should file a bug about the style checker getting this wrong.


More information about the webkit-reviews mailing list