[webkit-reviews] review granted: [Bug 68379] Remove calls to -[WebView _usesDocumentViews] from WebFrameLoaderClient.mm : [Attachment 107904] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 19 13:05:06 PDT 2011


Adam Roben (:aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 68379: Remove calls to -[WebView _usesDocumentViews] from
WebFrameLoaderClient.mm
https://bugs.webkit.org/show_bug.cgi?id=68379

Attachment 107904: Patch
https://bugs.webkit.org/attachment.cgi?id=107904&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107904&action=review


> Source/WebKit/mac/ChangeLog:6
> +	   Remove calls to -[WebView _usesDocumentViews] from
WebFrameLoaderClient.mm
> +	   https://bugs.webkit.org/show_bug.cgi?id=68379
> +
> +	   Reviewed by NOBODY (OOPS!).

Needs more explanation!

> Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm:1232
> +    // FIXME (Viewless): I assume we want the equivalent of this
optimization for viewless mode too.

Seems like we don't need this FIXME anymore.


More information about the webkit-reviews mailing list