[webkit-reviews] review granted: [Bug 68081] Page Scale affects window.scrollTo : [Attachment 107870] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted  review:
Bug 68081: Page Scale affects window.scrollTo
https://bugs.webkit.org/show_bug.cgi?id=68081

Attachment 107870: Patch
https://bugs.webkit.org/attachment.cgi?id=107870&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107870&action=review


> LayoutTests/fast/events/scale-and-scroll.html:20
> +	     var scaleOffset = 0;

Would be nice to test with a non-zero offset.

> Source/WebCore/page/DOMWindow.cpp:1146
> +    return static_cast<int>(view->scrollX() / m_frame->pageZoomFactor() /
m_frame->pageScaleFactor());

I'd slightly prefer scrollX / (pagezoomfactor * pagescalefactor)