[webkit-reviews] review denied: [Bug 58608] Groove/inset/outset borders show solid if the color is black : [Attachment 107810] Patch.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Antaryami Pandia
<xqb748 at motorola.com>'s request for review:
Bug 58608: Groove/inset/outset borders show solid if the color is black
https://bugs.webkit.org/show_bug.cgi?id=58608

Attachment 107810: Patch.
https://bugs.webkit.org/attachment.cgi?id=107810&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107810&action=review


The patch looks OK but you need to include pixel results.

> LayoutTests/fast/borders/border-Outset.html:9
> +	<style type="text/css">
> +		div {
> +			width: 200px;
> +			height: 200px;
> +			border: 20px outset #000;
> +			background-color: #0f0;
> +		}

Weird indentation here. Does it contain tabs? Please use 'black', 'green'
rather than hex values.

> LayoutTests/fast/borders/border-Outset.html:14
> +		 

No need for that.