[webkit-reviews] review granted: [Bug 63541] TextPosition refactoring: Merge ZeroBasedNumber and OneBasedNumber classes : [Attachment 107875] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 19 10:28:51 PDT 2011


Adam Barth <abarth at webkit.org> has granted Peter Rybin
<peter.rybin at gmail.com>'s request for review:
Bug 63541: TextPosition refactoring: Merge ZeroBasedNumber and OneBasedNumber
classes
https://bugs.webkit.org/show_bug.cgi?id=63541

Attachment 107875: Patch
https://bugs.webkit.org/attachment.cgi?id=107875&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107875&action=review


> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

This line will prevent the patch from being landed automatically.  In this
case, you should explain that there are no new tests because this patch is not
changing behavior.


More information about the webkit-reviews mailing list