[webkit-reviews] review granted: [Bug 67938] [Qt] [WK2] Implement popup menus in QDesktopWebView using QComboBox : [Attachment 107374] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>'s request for review:
Bug 67938: [Qt] [WK2] Implement popup menus in QDesktopWebView using QComboBox
https://bugs.webkit.org/show_bug.cgi?id=67938

Attachment 107374: Patch
https://bugs.webkit.org/attachment.cgi?id=107374&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107374&action=review


Looks good, let's start with this!
r=me with this tiny (perhaps personal) style nit:

> Source/WebKit2/UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp:87
> +    Q_ASSERT(comboBox);

Q_ASSERT -> ASSERT

> Source/WebKit2/UIProcess/qt/WebPopupMenuProxyQtDesktop.cpp:92
> +    Q_ASSERT(model);

Ditto.