[webkit-reviews] review requested: [Bug 68156] HTML5 <time> initial implementation : [Attachment 107832] time_element_initial_patch_01

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 19 04:12:15 PDT 2011

Vineet N Chaudhary <rgf748 at motorola.com> has asked  for review:
Bug 68156: HTML5 <time> initial implementation

Attachment 107832: time_element_initial_patch_01

------- Additional Comments from Vineet N Chaudhary <rgf748 at motorola.com>
Thanks Kent Tamura for the review comments,
Please find the updated patch.

> + * Copyright (C) 2010 Apple Inc. All rights reserved.
> Why does this have Apple copyright?
Copyrights updated

> Source/WebCore/html/HTMLTimeElement.cpp:86
> +    if (m_dateComponents.type())
> Should compare with DateComponents::Invalid.

> Source/WebCore/html/HTMLTimeElement.cpp:88
> +    return 0;
> You must not return 0. The specification says we must return null Date in
this case.

Also checking if datetime attribute is not present, then the element's 
textContent must be considered if valid.

More information about the webkit-reviews mailing list